Fix ChibiOS virtual serial short packet receive - #26356
Open
giri256 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Giridhar <giridharpavan593@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ChibiOS virtual serial currently asks the USB OUT queue for a full
CDC_EPSIZEbuffer. The queue copies short CDC packets into that buffer, but the existing boolean receive helper returnsfalseunless the requested size was filled exactly. As a result, normal short host writes are consumed and silently discarded beforevirtser_recv()is called.This change adds a byte-count receive helper and keeps the existing exact-size boolean wrapper for Raw HID and MIDI.
virtser_task()now dispatches exactly the bytes that were received, matching the LUFA implementation.Types of Changes
Issues Fixed or Closed by This PR
Checklist
Verification
.clang-formatconfiguration.git diff --checkpasses.The first-time QMK container image pull stalled locally, so the authoritative ChibiOS compile result is left to upstream CI.