Fix encoder pins for Portico75 to resolve #25051 - #26343
Open
normanr wants to merge 1 commit into
Open
Conversation
The mapping of CCW=VOLD, CW=VOLU was wrong in the original commit 13821fd, but wasn't noticed because the pin mapping was _also_ wrong. The encoder mapping was fixed in commit a73014f but that resulted in the encoder working backwards. This commit corrects the pin mapping so that the encoder works as expected. Fixes qmk#25051
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The mapping of CCW=VOLD, CW=VOLU was wrong in the original commit 13821fd, but wasn't noticed because the pin mapping was also wrong. The encoder mapping was fixed in commit a73014f but that resulted in the encoder working backwards. This commit corrects the pin mapping so that the encoder works as expected.
Types of Changes
Issues Fixed or Closed by This PR
Checklist