perf: lazy regex - #64
Merged
Merged
Conversation
Every regex/search-type magic rule was compiled from its pattern string on every database deserialization, regardless of whether that rule was ever evaluated -- 369 compilations on every wiza invocation using the embedded database. Wrap RegexTest's compiled Regex in a OnceLock, populated eagerly when a rule is parsed from source (so a malformed pattern still fails at build/parse time as before) but left empty across deserialization, compiling lazily on first match attempt instead. A compile failure at that point falls back to no-match rather than propagating an error, since MagicDb::deserialize accepts arbitrary serialized input, not just databases this build itself produced. Also store each pattern's capture-group count as a plain field, computed once when the regex is actually compiled, so the static strength/ranking computation (which runs at parse time only) no longer needs to touch the lazy regex at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.