Skip to content

fix(helper): sanitize uuid in log_to_file_queue to prevent path traversal (CWE-22) #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebastionoss wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(helper): sanitize uuid in log_to_file_queue to prevent path traversal (CWE-22) #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion modules/helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,16 @@ function get_log_file (uuid) {
}

function log_to_file_queue (uuid, msg, table = false, argv = undefined) {
// Sanitize uuid before using it as part of a file path. Several callers
// pass req.body.uuid directly (e.g. /cancel, /analyze_string, fast/slow/
// special scans, string-analysis), so an unsanitized value such as
// '../foo' would let the request write outside the logs/ directory.
// Use the same allow-list get_log_file() applies so both helpers always
// resolve to the same path for a given uuid.
const _uuid = String(uuid).replace(/[^a-zA-Z0-9\-]+/g, '')
logs_queue = logs_queue.then(function () {
return new Promise(function (resolve) {
const temp_log_file = slash(path.join('logs', uuid + '_log.txt'))
const temp_log_file = slash(path.join('logs', _uuid + '_log.txt'))
fs.appendFile(temp_log_file, msg + '\n', function (err, data) {
if (table) {
msg.forEach((item, index) => {
Expand Down