Fix #6297: 🐛 Fix inline Year datepicker Keyboard Navigation Accessibility#82
Open
balajis-qb wants to merge 1 commit into
Open
Fix #6297: 🐛 Fix inline Year datepicker Keyboard Navigation Accessibility#82balajis-qb wants to merge 1 commit into
balajis-qb wants to merge 1 commit into
Conversation
YearPicker was not applying the `react-datepicker__day--keyboard-selected` class during keyboard navigation when rendered in inline mode. The issue was caused by an unnecessary `!inline` check in `isKeyboardSelected`, which prevented the keyboard-selected state from being applied even when navigation was active. Removing this condition restores consistent behavior across: - Default DatePicker - MonthPicker - YearPicker (showYearPicker) Keyboard navigation now correctly highlights the focused year in inline mode. Closes Hacker0x01#6297
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linked issue: Hacker0x01#6297
Problem
In
showYearPickermode, keyboard navigation does not visually highlight the active (focused) year when the DatePicker is rendered withinline.This behavior is inconsistent with:
showMonthYearPicker)Root cause:
isKeyboardSelectedinsrc/year.tsxincludes a!this.props.inlineconditionreact-datepicker__day--keyboard-selectedclass from being applied in inline modeChanges
!this.props.inlinecheck fromisKeyboardSelectedBehavior Changes
Contribution checklist