fix: use ast.Constant.value in docs conf parse_version - #439
Merged
Erotemic merged 1 commit intoSep 15, 2026
Merged
Conversation
Sphinx docs failed to build on Python 3.14 with "AttributeError: 'Constant' object has no attribute 's'". The deprecated ast.Constant.s alias was removed in Python 3.14, so parse_version() in docs/source/conf.py raised while statically reading __version__ and Sphinx aborted with a ConfigError. Read node.value.value instead, which has been the canonical field since Python 3.8. Added tests/test_docs_conf.py, which extracts parse_version from conf.py (without importing sphinx) and asserts it parses a version string; it fails with the reported AttributeError before this change.
Member
|
Sorry for taking so long to click merge on a simple fix. These boilerplate files are generated via my xcookie package, so the real fix is in xcookie itself (and I think it already landed), but this is fine for a stop gap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #429
ast.Constant.swas removed in Python 3.14, soparse_version()indocs/source/conf.pyraisedAttributeError: 'Constant' object has no attribute 's'while statically reading__version__, and Sphinx aborted with aConfigError. Readingnode.value.valueinstead (the canonical field since Python 3.8) fixes the build.Added
tests/test_docs_conf.py, which extractsparse_versionfromconf.pywithout importing sphinx; it fails with the reportedAttributeErrorbefore this change and passes after.