Cap persistent kernel grids at logical PID count - #3160
Draft
yushangdi wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
min(total_pids, num_sms * num_sm_multiplier)Configtype with the autotuner's supported multipliers through 128Motivation
For a 2048-row fused RMS norm on GB300, the autotuner can search
num_sm_multiplier=16, but the old launcher emitted_NUM_SM * 16CTAs. Capping the physical grid emitsmin(2048, _NUM_SM * 16), making the intended 2048-CTA family available without changing the device-side persistent stride.With this change, a fresh full LFBO run stayed in the persistent family and selected a 16x configuration. Its canonical benchmark was 15.55 us, compared with 15.68 us for the previous Helion configuration in the same server process.
Testing
test/test_persistent_kernels.py: 32 passed, 1 skipped on GB300