Skip to content

[autotuner][cute] rename ab_stages "three" symbols that are no longer 3-only - #3151

Draft
calebmkim wants to merge 1 commit into
calebmkim/stack/34from
calebmkim/stack/35
Draft

[autotuner][cute] rename ab_stages "three" symbols that are no longer 3-only#3151
calebmkim wants to merge 1 commit into
calebmkim/stack/34from
calebmkim/stack/35

Conversation

@calebmkim

@calebmkim calebmkim commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Stacked PRs:


[autotuner][cute] rename ab_stages "three" symbols that are no longer 3-only

The tcgen05 AB-stage SMEM machinery originally only admitted a 3-stage
pipeline, so its symbols were named "...three...". They are now
depth-parametric (ab>=3, e.g. ab=4 for the narrow-N 16-bit cm2 tile and
ab=12 for fp8), so the "three" in the name is misleading. Rename the
symbols whose behavior spans more than ab=3; keep "three" only where the
code genuinely still gates on ab==3.

Renamed (parametric / ab>=3):
ab_stages_three_fits -> ab_stages_fits
ab_stages_three_search_constraints -> ab_stages_search_constraints
allow_ab_stages_three_search -> allow_ab_stages_search
allow_tcgen05_ab_stages_three_search -> allow_tcgen05_ab_stages_search
Tcgen05AbStagesThreeSearchConstraints -> Tcgen05AbStagesSearchConstraints
TCGEN05_AB_STAGES_THREE_RESERVED_SMEM_BYTES -> TCGEN05_AB_STAGES_RESERVED_SMEM_BYTES
TCGEN05_AB_STAGES_THREE_MIN_DEVICE_SMEM_OPTIN -> TCGEN05_AB_STAGES_MIN_DEVICE_SMEM_OPTIN
_tcgen05_ab_stages_three_search_constraints -> _tcgen05_ab_stages_search_constraints
_tcgen05_ab_stages_three_fits -> _tcgen05_ab_stages_fits
ab_stages_three_dtype_bytes / _device (kwargs) -> ab_stages_dtype_bytes / _device

Kept "three" (genuinely ab==3-only): _fix_ab_stages_three_search_config
and its _fix_tcgen05_ab_stages_three_search_config wrapper, which still
early-return unless tcgen05_ab_stages == 3.

Pure rename; no behavior change.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

… 3-only

The tcgen05 AB-stage SMEM machinery originally only admitted a 3-stage
pipeline, so its symbols were named "..._three_...". They are now
depth-parametric (ab>=3, e.g. ab=4 for the narrow-N 16-bit cm2 tile and
ab=12 for fp8), so the "three" in the name is misleading. Rename the
symbols whose behavior spans more than ab=3; keep "three" only where the
code genuinely still gates on ab==3.

Renamed (parametric / ab>=3):
  ab_stages_three_fits                       -> ab_stages_fits
  ab_stages_three_search_constraints         -> ab_stages_search_constraints
  allow_ab_stages_three_search               -> allow_ab_stages_search
  allow_tcgen05_ab_stages_three_search       -> allow_tcgen05_ab_stages_search
  Tcgen05AbStagesThreeSearchConstraints      -> Tcgen05AbStagesSearchConstraints
  TCGEN05_AB_STAGES_THREE_RESERVED_SMEM_BYTES -> TCGEN05_AB_STAGES_RESERVED_SMEM_BYTES
  TCGEN05_AB_STAGES_THREE_MIN_DEVICE_SMEM_OPTIN -> TCGEN05_AB_STAGES_MIN_DEVICE_SMEM_OPTIN
  _tcgen05_ab_stages_three_search_constraints -> _tcgen05_ab_stages_search_constraints
  _tcgen05_ab_stages_three_fits              -> _tcgen05_ab_stages_fits
  ab_stages_three_dtype_bytes / _device (kwargs) -> ab_stages_dtype_bytes / _device

Kept "three" (genuinely ab==3-only): _fix_ab_stages_three_search_config
and its _fix_tcgen05_ab_stages_three_search_config wrapper, which still
early-return unless tcgen05_ab_stages == 3.

Pure rename; no behavior change.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

stack-info: PR: #3151, branch: calebmkim/stack/35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant