Preserve nested control-flow subgraphs during pt2e convert#4540
Open
atharvjairath wants to merge 1 commit into
Open
Preserve nested control-flow subgraphs during pt2e convert#4540atharvjairath wants to merge 1 commit into
atharvjairath wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4540
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4455.
GraphModule.delete_all_unused_submodules()only inspects the immediate graph, soconvert()could delete submodules that are referenced only from nested control-flow subgraphs. In nestedwhile_loopcases, this left dangling references and causedDuplicateDQPassgraph linting to fail.This adds a recursion-aware cleanup wrapper that preserves submodules referenced from nested
GraphModulechildren, and adds a regression test covering nestedwhile_loopconversion.Test plan:
python -m ruff check torchao/quantization/pt2e/convert.py test/quantization/pt2e/test_quantize_pt2e.pypython -m pytest test/quantization/pt2e/test_quantize_pt2e.py::TestQuantizePT2E::test_nested_while_loop_convert_preserves_subgraphs -qpython -m pytest test/quantization/pt2e/test_duplicate_dq.py -qgit diff --check