Re-enable building under a free-threaded Python interpreter#4537
Open
nascheme wants to merge 1 commit into
Open
Re-enable building under a free-threaded Python interpreter#4537nascheme wants to merge 1 commit into
nascheme wants to merge 1 commit into
Conversation
Free-threaded interpreters do not support the CPython Limited C API, and hence use of the limited API has to be disabled. With this one change, `torchao` builds fine. The `is_freethreaded` function is in widespread use, and documented as the canonical way of doing this check here: https://py-free-threading.github.io/running-gil-disabled/#check-if-using-a-free-threaded-build This re-applies pytorch#4428 (commit f43befe), which was inadvertently reverted by pytorch#4446 ("Back out D105996100 — breaks `fbpkg build light_cli`"). That back-out was meant to revert only the multi-ISA work in pytorch#4159 (D105996100), but instead of computing a reverse diff it restored a whole-file snapshot of setup.py that predated both pytorch#4159 and pytorch#4428, silently clobbering the free-threading support. Re-applied on top of the current `add_options_for_x86` base; the only adaptation from the original is the placement of `is_freethreaded()` (both functions are kept). (cherry picked from commit f43befe) Assisted-by: Claude
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4537
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-applies the changes from #4428.
Free-threaded interpreters do not support the CPython Limited C API, and hence use of the limited API has to be disabled. With this one change,
torchaobuilds fine.The
is_freethreadedfunction is in widespread use, and documented as the canonical way of doing this check here:https://py-free-threading.github.io/running-gil-disabled/#check-if-using-a-free-threaded-build
PR #4428 (commit f43befe) was inadvertently reverted by #4446 ("Back out D105996100 — breaks
fbpkg build light_cli"). That back-out was meant to revert only the multi-ISA work in #4159 (D105996100), but instead of computing a reverse diff it restored a whole-file snapshot of setup.py that predated both #4159 and #4428, silently clobbering the free-threading support.Re-applied on top of the current
add_options_for_x86base; the only adaptation from the original is the placement ofis_freethreaded()(both functions are kept).(cherry picked from commit f43befe)