gh-153171: Produce specialized syntax errors for 'not' after an operator in more positions#153175
Merged
serhiy-storchaka merged 1 commit intoJul 6, 2026
Merged
Conversation
… operator in more positions Move the invalid_factor rule from term to factor and the invalid_arithmetic rule from shift_expr to sum, so that they are tried at all positions where the invalid construct can occur. Previously a generic "invalid syntax" error was reported for constructs like "1 << 2 + not x" or "1 * + not x". Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
pablogsal
approved these changes
Jul 6, 2026
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the
invalid_factorerror rule fromtermtofactorand theinvalid_arithmeticerror rule fromshift_exprtosum, so that they are tried at all positions where the invalid construct can occur, not only where the rule which previously contained them starts.Previously a generic error was reported when the construct occurred at a deeper position:
Now all of them report
SyntaxError: 'not' after an operator must be parenthesized.All previously produced error messages are unchanged: this only produces specialized errors where a generic error was reported before.
🤖 Generated with Claude Code