-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
gh-153060: Add an empty frozendict singleton #153061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vstinner
wants to merge
6
commits into
python:main
Choose a base branch
from
vstinner:frozendict_empty
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+190
−36
Open
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2e450b1
gh-153060: Add an empty frozendict singleton
vstinner 609b8d8
Add NEWS entry
vstinner 4815d54
Fix test_set: fix frozendict_or()
vstinner b2f1dfe
Test that the singleton is not tracked and is immortal
vstinner 0cd588d
Add more tests
vstinner 959c77c
Fix singleton test: pass an empty generator, not a list
vstinner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Core_and_Builtins/2026-07-05-05-39-16.gh-issue-153060.p1G8nO.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Add an empty :class:`frozendict` singleton. Patch by Victor Stinner. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Singletons are usually supposed to be stored on
_PyRuntime.static_objects.singletons, not on the interpreter state. Is there a reason we're deviating from that convention here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the empty frozendict singleton to
_PyRuntime.static_objects.singletonswould require to initialize aPyFrozenDictObjectstructure statically which is complicated.PyFrozenDictObjectinherits fromPyDictObjectwhich has these two members:PyDictKeysObject *ma_keysPyDictValues *ma_valuesWe should get access to this
empty_keys_struct(Py_EMPTY_KEYS) outsidedictobject.c.Pre-computing hash() is also complicated:
Well. Adding _PyDict_Init() and _PyDict_Fini() to allocate the empty frozendict singleton using
dictobject.ccode was simpler for me.