Skip to content

fix(naturaldelta): catch OverflowError for float('inf')/float('-inf') (#333) #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mukller wants to merge 4 commits into
base: main
Choose a base branch
from
+26 −3
Open

fix(naturaldelta): catch OverflowError for float('inf')/float('-inf') (#333) #363

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe0bf42
fix(naturaldelta): catch OverflowError for float('inf') (#333)
Mukller Jul 29, 2026
e16584e
fix(naturaldelta): only suppress OverflowError for non-finite floats
Mukller Jul 30, 2026
ac55bbb
test: regression for #333 non-finite float OverflowError in naturaldelta
Mukller Jul 30, 2026
ca10a45
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/humanize/time.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,6 @@ def naturaldelta(
converted to int (cannot be float due to 'inf' or 'nan').
In that case, a `value` is returned unchanged.

Raises:
OverflowError: If `value` is too large to convert to datetime.timedelta.

Examples:
Compare two timestamps in a custom local timezone::

Expand Down Expand Up @@ -151,7 +148,7 @@ def naturaldelta(
int(value) # Explicitly don't support string such as "NaN" or "inf"
value = float(value)
delta = dt.timedelta(seconds=value)
except (ValueError, TypeError):
except (ValueError, TypeError, OverflowError):
return str(value)

use_months = months
Expand Down