Repository navigation
Conversation
ApproxScalar.__eq__ only handled a NaN expected value. A Decimal NaN actual value reached the ordering comparison for the tolerance, which raises decimal.InvalidOperation. Return False for a NaN actual value before that comparison, matching the existing float behavior.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15335.
approx()raiseddecimal.InvalidOperationwhen the actual value wasDecimal("NaN")and the expected value was finite. A float NaN in the same place compares unequal, but the ordering comparison for the tolerance raises for Decimal.This returns
Falsebefore the tolerance check when the actual value is NaN, matching the existing handling of a NaN expected value.Added a regression test covering a scalar,
nan_ok=Trueand a list.Tests:
python -m pytest testing/python/approx.py(158 passed, 25 skipped).