Repository navigation
Add CHAP, EAP-GTC, MS-CHAPv2, EAP-MSCHAPv2 - #44
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nicholasamorim
force-pushed
the
feat/chap-eap
branch
from
June 4, 2026 12:07
664e34e to
17c23a3
Compare
Bundles a small MD4 for the NT password hash and pulls DES from cryptography via a new [mschap] extra. Each method gets a runnable scenario under scenarios/ and an entry in docs/auth.md. Fixes a latent EAP-MD5 bug where the encoder appended a second Message-Authenticator on top of the one prepare_outgoing already stamped, every conformant server rejected it. Tests missed it because they mocked the transport; the new scenario hits the real wire path.
nicholasamorim
force-pushed
the
feat/chap-eap
branch
from
June 4, 2026 12:12
17c23a3 to
bbc5ec9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundles a small MD4 for the NT password hash and pulls DES from cryptography via a new [mschap] extra. Each method gets a runnable scenario under scenarios/ and an entry in docs/auth.md.
Fixes a latent EAP-MD5 bug where the encoder appended a second Message-Authenticator on top of the one prepare_outgoing already stamped, every conformant server rejected it. Tests missed it because they mocked the transport; the new scenario hits the real wire path.