Repository navigation
Fix accumulated validation error counts across module updates - #305
Merged
mrbean-bremen merged 1 commit intoOct 26, 2026
Merged
mrbean-bremen merged 1 commit into
mrbean-bremen merged 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
==========================================
+ Coverage 89.82% 90.42% +0.59%
==========================================
Files 15 21 +6
Lines 1632 2130 +498
==========================================
+ Hits 1466 1926 +460
- Misses 166 204 +38 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the changes
ValidationResult.add_tag_errorsupdates the stored module map but calculates the count delta from the incoming batch size. Repeated updates can therefore reduce the total even when retained errors are unchanged or increase.Calculate the delta from the merged map instead. This preserves per-module tag deduplication, replacement of existing errors, and errors counted separately from module maps.
Added regression coverage for disjoint, overlapping, repeated and empty updates, module separation, and existing counts. The production change is one line.
Validation performed on Python 3.12:
Hosted validation at
4987a6e3: the upstream test matrix passes on Linux, macOS and Windows; pre-commit.ci also passes.No new dependency or public interface change.
Tasks
Documentation build: not applicable; no documentation page or API documentation changed.