Skip to content

Fix logical error in defining existing modules - #295

Merged
mrbean-bremen merged 1 commit into
pydicom:mainfrom
mrbean-bremen:fix-existing-modules
Sep 9, 2026
Merged

mrbean-bremen merged 1 commit into
pydicom:mainfrom
mrbean-bremen:fix-existing-modules

Conversation

@mrbean-bremen

@mrbean-bremen mrbean-bremen commented Sep 9, 2026 •

Copy link
Copy Markdown
Member

Tasks

  • Unit tests added that reproduce the issue or prove feature is working
  • Fix or feature added
  • Entry to release notes added
  • Pre-commit CI shows no errors
  • Unit tests passing

@codecov-commenter

codecov-commenter commented Sep 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.38%. Comparing base (e8644e2) to head (a26dd9f).
⚠️ Report is 218 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   89.82%   90.38%   +0.55%     
==========================================
  Files          15       21       +6     
  Lines        1632     2121     +489     
==========================================
+ Hits         1466     1917     +451     
- Misses        166      204      +38     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- if tags belonging to a user-defined module also belong to different mandatory modules,
 the module was erroneously seen as present
@mrbean-bremen
mrbean-bremen merged commit a49e823 into pydicom:main Sep 9, 2026
18 checks passed
@mrbean-bremen
mrbean-bremen deleted the fix-existing-modules branch September 9, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive for Shared Functional Group

2 participants