Fix: collapse dimension for single nested tuple MultiIndex key#11421
Open
C1-BA-B1-F3 wants to merge 1 commit into
Open
Fix: collapse dimension for single nested tuple MultiIndex key#11421C1-BA-B1-F3 wants to merge 1 commit into
C1-BA-B1-F3 wants to merge 1 commit into
Conversation
When indexing with a single nested tuple key (where one level has tuple-valued entries), the dimension was incorrectly preserved because _is_nested_tuple() detected the nested tuples and used get_locs() which returns an array, instead of get_loc() which returns a scalar. The fix tries get_loc() first when a nested tuple is detected, falling back to get_locs() only if get_loc() fails (e.g., for slice-in-tuple multi-value selections). Fixes pydata#11341
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When indexing a DataArray with a single nested tuple MultiIndex key (where one level has tuple-valued entries), the result is located correctly but the MultiIndex dimension is incorrectly preserved in the output.
Root Cause
In
PandasMultiIndex.sel(), the_is_nested_tuple()helper detected that((1, 1), 2)contains a sub-tuple(1, 1)and routed it toget_locs(), which returns an array. But this tuple is actually a single key for the MultiIndex (levela=(1, 1), levelb=2), andget_loc()correctly returns a scalar integer for it.Fix
Try
get_loc()first when a nested tuple is detected. If it succeeds (returns a scalar), use that result. If it raisesInvalidIndexErrororKeyError(e.g., for slice-in-tuple multi-value selections like(1, slice(1, 2))), fall back toget_locs().Tests
Added a regression test
test_sel_nested_tuple_key_collapses_dimensionthat verifies the dimension collapses for single nested tuple keys.Closes #11341