Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion xarray/namedarray/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ def module_available(module: str, minversion: str | None = None) -> bool:

if minversion is not None:
version = importlib.metadata.version(module)

if version is None:
return False
return Version(version) >= Version(minversion)

return True
Expand Down
29 changes: 29 additions & 0 deletions xarray/tests/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from collections.abc import Hashable
from types import EllipsisType
from unittest.mock import patch

import numpy as np
import pandas as pd
Expand All @@ -15,6 +16,7 @@
infix_dims,
iterate_nested,
)
from xarray.namedarray.utils import module_available
from xarray.tests import assert_array_equal, requires_dask


Expand Down Expand Up @@ -400,3 +402,30 @@ def test_attempt_import() -> None:
attempt_import(module="foo")
with pytest.raises(ImportError, match="The foo package is required"):
attempt_import(module="foo.bar")


class TestModuleAvailable:
def test_existing_module_without_version(self) -> None:
assert module_available("numpy") is True

def test_existing_module_with_version(self) -> None:
assert module_available("numpy", minversion="1.0.0") is True

def test_nonexistent_module(self) -> None:
assert module_available("nonexistent_module_xyz") is False

def test_nonexistent_module_with_version(self) -> None:
assert module_available("nonexistent_module_xyz", minversion="1.0.0") is False

@patch("importlib.metadata.version", return_value=None)
def test_module_with_none_version(self, mock_version) -> None:
"""Regression test for GH#11344: importlib.metadata.version() returning None."""
module_available.cache_clear()
result = module_available("numpy", minversion="1.0.0")
assert result is False

@patch("importlib.metadata.version", return_value=None)
def test_module_with_none_version_no_minversion(self, mock_version) -> None:
module_available.cache_clear()
result = module_available("numpy")
assert result is True
Loading