Skip to content

BLD: centralize NPY_* macro defs to setup.py #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neutrinoceros merged 1 commit into from
May 31, 2026
Merged

BLD: centralize NPY_* macro defs to setup.py #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion bottleneck/src/bottleneck.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
#define BOTTLENECK_H_

#include <Python.h>
#define NPY_NO_DEPRECATED_API NPY_1_11_API_VERSION
#include <numpy/arrayobject.h>
#include <bn_config.h>

Expand Down
5 changes: 4 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ classifiers = [
"Topic :: Scientific/Engineering",
]
requires-python = ">=3.10"
dependencies = ["numpy>=1.21.3"]
dependencies = [
# keep in sync with NPY_* macros (setup.py)
"numpy>=1.21.3",
]
dynamic = ["version"]

[project.urls]
Expand Down
8 changes: 8 additions & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@

import versioneer

define_macros = [
# keep in sync with runtime requirements (pyproject.toml)
("NPY_NO_DEPRECATED_API", "NPY_1_21_API_VERSION"),
]


class config(_config):
def run(self):
Expand Down Expand Up @@ -109,6 +114,7 @@ def prepare_modules():
"bottleneck.reduce",
sources=["bottleneck/src/reduce.c"],
depends=base_includes,
define_macros=define_macros,
extra_compile_args=["-O2"],
)
]
Expand All @@ -120,6 +126,7 @@ def prepare_modules():
"bottleneck/src/move_median/move_median.c",
],
depends=base_includes + ["bottleneck/src/move_median/move_median.h"],
define_macros=define_macros,
extra_compile_args=["-O2"],
)
]
Expand All @@ -128,6 +135,7 @@ def prepare_modules():
"bottleneck.nonreduce",
sources=["bottleneck/src/nonreduce.c"],
depends=base_includes,
define_macros=define_macros,
extra_compile_args=["-O2"],
)
]
Expand Down
Loading