[chore/headers-interface-defines] feat: add PYBIND11_NOINLINE_ATTR and PYBIND11_INLINE macros - #6131
Merged
Merged
Conversation
henryiii
force-pushed
the
feat/precompile-macro-infra
branch
from
August 12, 2026 02:18
a7492b8 to
2a03d53
Compare
henryiii
force-pushed
the
feat/precompile-macro-infra
branch
from
August 15, 2026 03:45
2a03d53 to
59ba815
Compare
rwgk
approved these changes
Aug 15, 2026
rwgk
left a comment
rwgk
left a comment
Collaborator
There was a problem hiding this comment.
Also reviewed with codex gpt-5.6-sol ultra: no issues found.
henryiii
force-pushed
the
feat/precompile-macro-infra
branch
from
August 17, 2026 04:50
59ba815 to
723bc46
Compare
Decompose PYBIND11_NOINLINE into the attribute part plus inline, and add PYBIND11_INLINE, which becomes empty under PYBIND11_PRECOMPILED. Groundwork for optional pre-compilation; all current expansions are unchanged and PYBIND11_INLINE is not used yet. Assisted-by: ClaudeCode:claude-fable-5
henryiii
force-pushed
the
feat/precompile-macro-infra
branch
from
September 27, 2026 02:19
723bc46 to
e5f1ff9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Stacked on #6130.
Decompose
PYBIND11_NOINLINEintoPYBIND11_NOINLINE_ATTR+inline(all three current expansions are reproduced exactly), and addPYBIND11_INLINE:inlineby default, empty whenPYBIND11_PRECOMPILEDis defined. This is the macro groundwork for optional pre-compilation (CLI11 and fmt use the same pattern; see also #2445 and #4001).PYBIND11_INLINEhas no uses yet, so this PR is a no-op refactor.Suggested changelog entry: