Conversation
This adds the secret:// resolving to the Environment in x-pre_deploy too. Further more the Environment is set to nil when commiting the container to the store. Fixes: psviderski#422 Signed-off-by: Miek Gieben <miek@miek.nl>
Signed-off-by: Miek Gieben <miek@miek.nl>
This changes the map, which we dont wont Signed-off-by: Miek Gieben <miek@miek.nl>
|
Opened #424 before I saw this, same two fixes. This one doesn't cover the gap for Also pulled the resolve loop into a shared helper instead of duplicating it in Whichever you want, I'll rebase the tests onto this one, or close 424. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the secret:// resolving to the Environment in x-pre_deploy too. Further more the Environment is set to nil when commiting the container to the store.
Fixes: #422