WIP upgrade to blacklight 8 - #1295
Open
Sarah Smulligan (Smullz622) wants to merge 24 commits into
Open
Conversation
… document RIS needed to be adjusted accordingly as well.
… with the BL 8 upgrade and Ruth gave the ok to just remove them
…is modifies how session_tracking_params is called as well
Alex Kiessling (ajkiessl)
requested changes
Jul 2, 2024
Alex Kiessling (ajkiessl)
left a comment
Alex Kiessling (ajkiessl)
left a comment
Contributor
There was a problem hiding this comment.
So far this looks good. There's a lot here so I'm kind of skimming over a lot of things, but there was only one thing that stood out to me.
Addresses issues with header_navbar tests, bookmark and share tests, and all those that were rendering the above components. Share menu still starts opened rather than opening on click.
Sarah Smulligan (Smullz622)
marked this pull request as ready for review
September 10, 2026 00:20
Contributor
Author
|
Finally ready for review! One thing to note, homepage doesn't have facets (Ruth is good with this change) but it's just blank space where they should be for now. I'm not going to focus on fixing that yet because it might get resolved in the bump to blacklight 9 I'm working on next. If that doesn't resolve it or we don't get that complete before the end of this cycle, I'll create a separate priority ticket to resolve that spacing before deploying. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1289