Initial implementation using kustomize and envsubst - #1
Conversation
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
|
🚀 Merging this PR will release Merging will trigger workflows 🛠️ Auto tagging enabled with label |
f9665d4 to
ed35f57
Compare
ed35f57 to
e2b5523
Compare
f3be9ea to
546f66d
Compare
|
Also why is this component in https://github.com/vshn? Afaict, there's nothing in here that would prevent it from being in https://github.com/projectsyn |
bd0eddc to
27f5016
Compare
Move is prepared, will do as soon as this review is complete |
simu
left a comment
There was a problem hiding this comment.
We should probably configure the ArgoCD app to use server-side apply, since the component deploys CRDs (probably also applies to capi-core). This can be done by adding the following in component/app.jsonnet:
local app = argocd.App('capi-provider-cloudscale', params.namespace) {
spec+: {
syncOptions+: [
'ServerSideApply=true',
],
}
};
024ba65 to
16f30e1
Compare
16f30e1 to
655fac6
Compare
This PR provides the initial implementation of the capi-provider-cloudscale component. It utilizes kustomize to build the manifests from the upstream provider repository and then substitutes variables on the generated output. It does so using https://github.com/a8m/envsubst, which will be included in the commodore image used for CI/CD. This simulates the behavior of clusterctl so we can use project syn to set up CAPI.
See also:
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.