Skip to content

[v3.31] felix/fv: wait for Felix to be ready before asserting on status files #13882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaaaaaaalex wants to merge 1 commit into
base: release-v3.31
Choose a base branch
from
+11 −8
Open

[v3.31] felix/fv: wait for Felix to be ready before asserting on status files #13882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions felix/fv/pod_setup_wait_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,18 @@ var _ = infrastructure.DatastoreDescribe("_BPF-SAFE_ Pod setup status wait", []a
}
}

It("should receive DataplaneInSync message from the dataplane", func() {
startFelixAndWaitForInSync := func() {
tc.Felixes[0].TriggerDelayedStart()
tc.Felixes[0].WaitForReady()
Eventually(dataplaneInSyncReceivedC, "10s").Should(BeClosed(), "receipt of DataplaneInSync message not seen in logs")
}

It("should receive DataplaneInSync message from the dataplane", func() {
startFelixAndWaitForInSync()
})

It("should create endpoint-status files in a directory named endpoint-status with the specified directory prefix", func() {
tc.Felixes[0].TriggerDelayedStart()
startFelixAndWaitForInSync()
var filenames [2]string
var statCmds [2]func() error
for i := range dummyWorkloads {
Expand Down Expand Up @@ -114,16 +119,15 @@ var _ = infrastructure.DatastoreDescribe("_BPF-SAFE_ Pod setup status wait", []a
tc.Felixes[0].Exec("touch", name)

By("Waiting for Felix's status file reporter to come in-sync")
tc.Felixes[0].TriggerDelayedStart()
Eventually(dataplaneInSyncReceivedC, "10s").Should(BeClosed(), "receipt of DataplaneInSync message not seen in logs")
startFelixAndWaitForInSync()

By("checking if the stale file has been cleaned up")
fileExists := func() bool {
logrus.WithField("file", name).Info("Checking existence of expected file in endpoint-status dir")
_, err := tc.Felixes[0].ExecOutput("stat", name)
return err == nil
}
Eventually(fileExists).Should(BeFalse(), "Stale file was not cleaned up by Felix")
Eventually(fileExists, "10s", "500ms").Should(BeFalse(), "Stale file was not cleaned up by Felix")
})

It("should re-use pre-existing files after a restart", func() {
Expand All @@ -144,11 +148,10 @@ var _ = infrastructure.DatastoreDescribe("_BPF-SAFE_ Pod setup status wait", []a
By("creating a file with the determined name before Felix starts")
expectedFilename := filepath.Join("/tmp/endpoint-status", filename)
tc.Felixes[0].Exec("mkdir", "/tmp/endpoint-status")
tc.Felixes[0].Exec("touch", filename)
tc.Felixes[0].Exec("touch", expectedFilename)

By("waiting for Felix's status file reporter to become in-sync")
tc.Felixes[0].TriggerDelayedStart()
Eventually(dataplaneInSyncReceivedC, "10s").Should(BeClosed(), "receipt of DataplaneInSync message not seen in logs")
startFelixAndWaitForInSync()

output, err := tc.Felixes[0].ExecOutput("cat", expectedFilename)
Expect(err).NotTo(HaveOccurred(), "stat call failed while trying to create a file")
Expand Down
Loading