e2e: use the gcloud credential helper for gcr pulls - #13866
Open
alexh-tigera wants to merge 1 commit into
Open
Conversation
marvin-tigera
added
release-note-required
alexh-tigera
added
docs-not-required
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The PR description still has the release note set to TBD, which should be replaced with a one-line note or None before merging.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Semaphore e2e global prologue to configure Docker to use the gcloud credential helper for Google Container Registry pulls, avoiding failures caused by short-lived static GCR credentials in the copied Docker config during long-running jobs.
Changes:
- After copying
~/secrets/docker_cfg.jsoninto~/.docker/config.json, rungcloud auth configure-docker --quietso GCR pulls use freshly minted tokens. - Add inline documentation explaining why the helper is needed for long-running jobs.
File summaries
| File | Description |
|---|---|
.semaphore/end-to-end/scripts/global_prologue.sh |
Configures Docker to use gcloud credential helper after copying the static Docker config, preventing GCR pull failures later in the job. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
alexh-tigera
force-pushed
the
e2e-gcr-cred-helper
branch
from
September 10, 2026 18:30
7e8a6aa to
fcbf55e
Compare
The e2e prologue copies a static docker_cfg.json to ~/.docker/config.json. The gcr credentials in it are short-lived, so once a job exceeds that time, nothing can pull from gcr any more. This means that lens-report:stable can't upload results to Lens.
alexh-tigera
force-pushed
the
e2e-gcr-cred-helper
branch
from
September 10, 2026 19:33
fcbf55e to
843f31f
Compare
radTuti
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The e2e prologue copies a static docker_cfg.json to ~/.docker/config.json. The gcr credentials in it are short-lived, so once a job exceeds that time, nothing can pull from gcr any more. This means that lens-report:stable can't upload results to Lens.
Configure the credential helper after the copy, as .semaphore/release/hashrelease_enterprise.yml already does.
Release note:
AI assistance: None