feat: define auth-gating lane for exposed homelab service UIs#197
Open
clubanderson wants to merge 1 commit into
Open
feat: define auth-gating lane for exposed homelab service UIs#197clubanderson wants to merge 1 commit into
clubanderson wants to merge 1 commit into
Conversation
…tbluefin#61) Add the auth-gating validation lane under the access/TLS epic (projectbluefin#53), layering credential enforcement on top of the HTTPS transport security proven by projectbluefin#58. Changes: - Add §6 to homelab-contracts.md defining the auth-gating lane with minimum evidence requirements (unauthenticated rejection, challenge headers, bad-credential rejection, valid-credential acceptance, TLS-only auth, no credential leakage in 401 body) - Add test_auth_probe.py with six pytest checks that produce the required evidence artifacts - Add argo/homelab-auth-probe.yaml convenience workflow for submitting the auth lane (auth-mode=true) - Add run-homelab-auth Justfile recipe - Update workload matrix table and blockers to reflect projectbluefin#61 implemented - Explicitly defer SSO/OIDC, OAuth2 proxy, per-service auth, and credential rotation as follow-up work Signed-off-by: Andy Anderson <andy@clubanderson.com> Signed-off-by: unknown <unknown@users.noreply.github.com>
hanthor
approved these changes
Jun 6, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
LGTM — well-structured test/infra addition, clean code.
6 tasks
hanthor
requested changes
Jun 16, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
Superseded by #205. This PR implements basic auth-gating (121-line test, 6 tests) but #205 provides a far more comprehensive implementation: 260-line test with 15 tests, TLS integrity checks, artifact capture, better failure diagnostics, more thorough docs.
Both PRs add tests/homelab_access/test_auth_probe.py -- direct file conflict.
Recommendation: Close in favor of #205.
hanthor
approved these changes
Jul 1, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
Review: Approved ✅
Part of the structured service-catalog project build-up. Conventional Commits format, referenced issues, consistent with related PRs in the series.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defines the auth-gating validation lane under the access/TLS epic (#53), closing #61. This layers credential enforcement on top of the HTTPS transport security proven by #58.
docs/homelab-contracts.mddefining what counts as acceptable authenticated vs. unauthenticated exposure, with six minimum evidence artifactstests/homelab_access/test_auth_probe.pywith six pytest checks: unauthenticated rejection (401), challenge header validation (WWW-Authenticate: Basic realm="homelab"), bad-credential rejection, valid-credential acceptance, auth-over-TLS evidence, and no-credential-leakage in 401 bodyargo/homelab-auth-probe.yamlconvenience workflow (auth-mode=true)run-homelab-authJustfile recipeFollow-up work called out explicitly
Links
Test plan
just run-homelab-authsubmits the workflow withauth-mode=true/tmp/results/WWW-Authenticatechallengeaccess-ok