Skip to content

[GSoC week 1] Add collapsible details to show the newly added content to the English version of the file #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aashishpanthi wants to merge 4 commits into
base: v1
Choose a base branch
from
Open

[GSoC week 1] Add collapsible details to show the newly added content to the English version of the file #1424

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1bbe581
add details feature which shows the new addition in English language …
aashishpanthi Jun 1, 2026
9cb73c3
Add comments and text readability
aashishpanthi Jun 1, 2026
70a2cd1
fixed the small typo
aashishpanthi Jun 4, 2026
2557cae
remove unnecessary code snippet
aashishpanthi Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion .github/actions/translation-tracker/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ class GitHubCommitTracker {
let isTruncated = false;
if (patch) {
const lines = patch.split('\n');
const maxLines = 80;
const maxLines = 50;
if (lines.length > maxLines) {
patchSnippet = lines.slice(0, maxLines).join('\n');
isTruncated = true;
Expand Down Expand Up @@ -407,6 +407,24 @@ class GitHubCommitTracker {
});
}

// English diff. It shows the actual content changes in the English file.
if (englishDiff && (englishDiff.compareUrl || englishDiff.patchSnippet)) {
body += `### 🧩 Recent English Diff\n\n`;
if (englishDiff.compareUrl) {
body += `- [🔍 View full compare](${englishDiff.compareUrl})\n\n`;
}
if (englishDiff.patchSnippet) {
body += `<details>\n<summary>Show patch snippet</summary>\n\n`;
body += `\`\`\`diff\n${englishDiff.patchSnippet}\n\`\`\`\n\n`;
if (englishDiff.isTruncated) {
body += `_(Patch snippet truncated. Use the compare link above for the full diff.)_\n\n`;

@Divyansh013 Divyansh013 Jun 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by compare link are we referring to View full compare used above?

@aashishpanthi aashishpanthi Jun 4, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by compare link are we referring to View full compare used above?

yes we are

@Divyansh013 Divyansh013 Jun 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then what if englishDiff.compareUrl is false but englishDiff.patchSnippet is true? your driving if condition will satisfy but there will be no compare link right?

@aashishpanthi aashishpanthi Jun 11, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then what if englishDiff.compareUrl is false but englishDiff.patchSnippet is true? your driving if condition will satisfy but there will be no compare link right?

I was going to say yes, but I looked at the code, and I don't see a scenario where the compareUrl is false. Inside getRecentDiffForFile() there is no instance where the function will return the null compareUrl.

Please let me know if I missed anything.

@aashishpanthi aashishpanthi Jun 25, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Divyansh013 remove the unncessary coditional statement as we discussed

}
body += `</details>\n\n`;
} else {
body += `_(Could't generate preview of the differences for this change. Use the compare link above to see the full diff.)_\n\n`;

@Divyansh013 Divyansh013 Jun 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo, should be Couldn't

}
}

body += `### 🔗 Quick Links
- [📄 Current English file](https://github.com/${this.owner}/${this.repo}/blob/${this.currentBranch}/${englishFile})

Expand Down