This repository was archived by the owner on Jul 7, 2025. It is now read-only.
Add documentation for the ConfirmationDialog component - #943
Closed
francisfuzz wants to merge 8 commits into
Closed
Conversation
francisfuzz
commented
Jul 2, 2025
| <img | ||
| width="960" | ||
| alt="Anatomy of a ConfirmationDialog showing header, body content, and action buttons" | ||
| src="https://github.com/user-attachments/assets/fb545bc1-0b21-43dd-bfb4-378ffef894a8" |
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
📝 This isn't final. We'll need a "real" Anatomy here in place of this one, so it's here as a placeholder.
francisfuzz
commented
Jul 2, 2025
Comment on lines
+6
to
+7
| reactId: confirmation-dialog | ||
| figmaId: confirmation-dialog |
Contributor
Author
There was a problem hiding this comment.
❓ Question for reviewers: how do I validate these IDs are pointing to the correct reference outbound to the React source code or Figma URL?
francisfuzz
marked this pull request as ready for review
July 2, 2025 18:51
francisfuzz
commented
Jul 2, 2025
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
|
Closing, will re-work this ✌🏽 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://github.com/github/primer/issues/5198
This PR adds documentation for the
ConfirmationDialogcomponent. It follows the same convention as its sibling components with the metadata and imports at the top. I used Copilot Agent mode to contextualize the example based on what's inprimer/react's source code, and validated it on my own read.I believe this is at the 30% mark and don't expect it to be approved as-is.
For reviewers, here's the deploy preview: https://primer-34f3f200fc-26441320.drafts.github.io/components/confirmation-dialog
And, my questions:
Thank you! 🙇🏽