Repository navigation
Conversation
The "Deploy to production" button opened an AlertDialog modal that took the user out of the board. Replace it with an in-place two-click confirm: the first click arms the button (destructive variant, label changes to "Click again — ships all of main"), the second fires; it auto-reverts after 4s and disarms on blur. No overlay, never leaves the base interface. Removes the AlertDialog usage + its modal i18n keys (deploy_confirm_title/ body/action, deploy_cancel); adds deploy_confirm_inline, deploy_confirm_hint (tooltip carrying the "ships all of main" warning), deploy_in_progress, in en + zh-Hans. views typecheck + eslint clean; swimlanes test +1 case (arm → no dispatch, second click → mutateAsync once) → 9 pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Deploy to production" action used a full-screen AlertDialog modal — heavy for something you trigger from the board, and it yanks you out of context. This swaps it for an in-place two-click confirm:
destructivevariant and the label becomes "Click again — ships all of main." No overlay.Removes the AlertDialog + its modal-only i18n keys; adds
deploy_confirm_inline/deploy_confirm_hint/deploy_in_progress(en + zh-Hans).Test plan
ship-deploy-swimlanes.test.tsxgains a case asserting first click does not dispatch + relabels, second click calls the promote mutation once → 9 pass.🤖 Generated with Claude Code