Render fieldcompare diff visualizations#883
Open
PranjalManhgaye wants to merge 1 commit into
Open
Conversation
MakisH
reviewed
Jul 18, 2026
MakisH
left a comment
MakisH
left a comment
Member
There was a problem hiding this comment.
Thank you for the PR! Some first comments, I will continue once I can run it.
| @@ -1 +1 @@ | |||
| - Archive fieldcompare diff VTK files into a `diff-results/` folder in each systemtest run directory on failure so they are easy to find in CI artifacts when investigating comparison failures (fixes [#441](https://github.com/precice/tutorials/issues/441)). Nested paths under `precice-exports/` are preserved under `diff-results/`. | |||
| - Archive fieldcompare diff VTK files into a `diff-results/` folder in each systemtest run directory on failure so they are easy to find in CI artifacts when investigating comparison failures (fixes [#441](https://github.com/precice/tutorials/issues/441)). Nested paths under `precice-exports/` are preserved under `diff-results/`, and each numeric point field is rendered headlessly as a sphere-glyph PNG in `diff-results/visualizations/`. | |||
Member
There was a problem hiding this comment.
Links to both PRs should be mentioned here. It looks like this previously slipped.
Member
There was a problem hiding this comment.
It looks like we need more dependencies. Running on GHA, I get:
2026-07-18 08:56:07.732 ( 2.224s) [ 7FE8965761C0]vtkOpenGLRenderWindow.c:645 WARN| Failed to load EGL! Please install the EGL library from your distribution's package manager.
2026-07-18 08:56:07.732 ( 2.225s) [ 7FE8965761C0]vtkOSOpenGLRenderWindow:149 WARN| libOSMesa not found. It appears that OSMesa is not installed in your system. Please install the OSMesa library from your distribution's package manager.
2026-07-18 08:56:07.734 ( 2.226s) [ 7FE8965761C0]vtkOpenGLRenderWindow.c:645 WARN| Failed to load EGL! Please install the EGL library from your distribution's package manager.
2026-07-18 08:56:07.734 ( 2.226s) [ 7FE8965761C0]vtkOSOpenGLRenderWindow:149 WARN| libOSMesa not found. It appears that OSMesa is not installed in your system. Please install the OSMesa library from your distribution's package manager.
CRITICAL: Fieldcompare returned non zero exit code, therefore Channel transport (fluid-openfoam, transport-openfoam) failed
Member
There was a problem hiding this comment.
The respective images could also be added to the _logs build artifact in the GHA workflow.
Even better would be if we could add them on the job summary. I guess that images on job summaries are supported, but I am not sure where to source the image from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Render archived fieldcompare diff VTK files as PNG images when result comparison fails.
Generate one image per numeric point field using distinct sphere glyphs and a generic automatically selected view.
Store images under
diff-results/visualizations/in the system-test artifacts.Keep visualization best-effort so rendering errors do not hide the original fieldcompare failure.
Fixes #441.
Test plan
Generated PNGs from synthetic scalar and vector VTK fields.
Verified the
archive-to-visualizationfailure path locally.Rendered five real
CI diff VTK files, producing 13 PNGs.Checked zero and non-zero differences visually.
Ran
pre-commitchecks successfully.