Skip to content

Fix passing MPI communicators Participant #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IshaanDesai merged 3 commits into from
Apr 10, 2026
Merged

Fix passing MPI communicators Participant #256

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9208cd1
Fix passing MPI communicators Participant
fsimonis Apr 10, 2026
73eca76
Added changelog
fsimonis Apr 10, 2026
67c017b
Update cyprecice/cyprecice.pyx
fsimonis Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

All notable changes to this project will be documented in this file.

## latest

* Fixed passing custom MPI communicators to the Participant https://github.com/precice/python-bindings/pull/256

## 3.4.0

* Added support for documentation rendering https://github.com/precice/python-bindings/pull/250
Expand Down
9 changes: 5 additions & 4 deletions cyprecice/cyprecice.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ cimport cyprecice
cimport numpy
import numpy as np
from mpi4py import MPI

Comment thread
fsimonis marked this conversation as resolved.
Outdated
import warnings
from libcpp.string cimport string
from libcpp.vector cimport vector
Expand Down Expand Up @@ -63,7 +64,7 @@ cdef class Participant:
Rank of the process
solver_process_size : int
Size of the process
communicator: mpi4py.MPI.Intracomm, optional
communicator: mpi4py.MPI.Comm, optional
Custom MPI communicator to use

Returns
Expand All @@ -82,10 +83,10 @@ cdef class Participant:
pass

def __cinit__ (self, solver_name, configuration_file_name, solver_process_index, solver_process_size, communicator=None):
cdef void* communicator_ptr
cdef size_t c_comm_addr;
if communicator:
communicator_ptr = <void*> communicator
self.thisptr = new CppParticipant.Participant (convert(solver_name), convert(configuration_file_name), solver_process_index, solver_process_size, communicator_ptr)
c_comm_addr = MPI._addressof(communicator)
self.thisptr = new CppParticipant.Participant (convert(solver_name), convert(configuration_file_name), solver_process_index, solver_process_size, <void*>c_comm_addr)
else:
self.thisptr = new CppParticipant.Participant (convert(solver_name), convert(configuration_file_name), solver_process_index, solver_process_size)
pass
Expand Down
Loading