You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @JoviDeCroock@rschristian , I reworked the use() implementation based on your feedback from #4970, especially around keeping it small, avoiding React-specific details in core, and not building it on top of order-sensitive hooks like useState or useContext.
The new PR implements use() for Promises and Contexts, with tests covering conditional calls, falsy promise values, rejection handling, shared promises, Context updates, exports, and TypeScript types. When you have time, could you take another look and let me know if this direction better matches Preact’s design philosophy?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use()support inpreact/hooksfor Promises and Contextsuse()order-insensitive by avoidinguseState/useContextinternallyusethrough compat default/types and add coverage for Promise, Context, conditional calls, falsy values, rejection, exports, and TS typesTests
npm test