Skip to content

[types] permit undefined createContext initial value#3407

Draft
developit wants to merge 2 commits into
mainfrom
types-createcontext-default-value
Draft

[types] permit undefined createContext initial value#3407
developit wants to merge 2 commits into
mainfrom
types-createcontext-default-value

Conversation

@developit

Copy link
Copy Markdown
Member

No description provided.

@coveralls

coveralls commented Jan 11, 2022

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.625% when pulling b6053a1 on types-createcontext-default-value into d4a3013 on master.

Comment thread src/index.d.ts
export interface PreactContext<T> extends Context<T> {}

export function createContext<T>(defaultValue: T): Context<T>;
export function createContext<T = undefined>(defaultValue: T): Context<T>;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe this?

Suggested change
export function createContext<T = undefined>(defaultValue: T): Context<T>;
export function createContext<T>(defaultValue: T): Context<T>;
export function createContext<T extends undefined>(defaultValue?: T): Context<T>;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants