build(deps): bump schemars from 0.8.22 to 1.2.2 - #183
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [schemars](https://github.com/GREsau/schemars) from 0.8.22 to 1.2.2. - [Release notes](https://github.com/GREsau/schemars/releases) - [Changelog](https://github.com/GREsau/schemars/blob/master/CHANGELOG.md) - [Commits](GREsau/schemars@v0.8.22...v1.2.2) --- updated-dependencies: - dependency-name: schemars dependency-version: 1.2.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
praxis-bot
left a comment
There was a problem hiding this comment.
schemars 0.8 → 1.2 is a major-version bump that will break compilation. See inline comment.
| prettyplease = "0.3.0" | ||
| syn = "3.0.5" | ||
| schemars = "0.8" | ||
| schemars = "1.2" |
There was a problem hiding this comment.
Critical: schemars 1.x removed the schemars::schema module entirely. xtask/src/api_codegen.rs does use schemars::schema::Schema;, which will fail to compile against schemars 1.2.
Additionally, typify = "0.8.0" expects schemars 0.8's Schema type in its TypeSpace::add_ref_types() API. Even if the import path is fixed to schemars::Schema, the type from schemars 1.2 is not the type typify 0.8 accepts, producing a type mismatch.
This bump requires either:
- Updating
api_codegen.rsand upgrading typify to a version that supports schemars 1.x, or - Keeping schemars at 0.8 until typify is updated.
|
Superseded by #186, which carries the Schemars 1.2.2 dependency update and the Typify compatibility fix in a standalone maintainer commit. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps schemars from 0.8.22 to 1.2.2.
Release notes
Sourced from schemars's releases.
... (truncated)
Changelog
Sourced from schemars's changelog.
... (truncated)
Commits
ed61863v1.2.2ae618c3Updatesynto v3 (#528)c072ea0docs: add missing attributes to table of contents (#517)015272fClippy fix (#512)944f727Bump bytes from 1.10.1 to 1.11.1 (#507)5ef5da1v1.2.14081b98Applyextend/transformattributes after any other attributes (#506)5bfec04v1.2.0f6b1f4cAddsmol_str03feature (#486)18826cdAdd test for changes from #452Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)