Update style of extended details on profile page#38196
Open
diquoks wants to merge 2 commits into
Open
Conversation
diquoks
commented
Jun 30, 2026
| { | ||
| var font = OsuFont.Default.With(size: 12); | ||
| const float vertical_spacing = 4; | ||
| const float horizontal_spacing = 20; |
Contributor
Author
There was a problem hiding this comment.
not needed actually, but i added it for consistency
Comment on lines
+132
to
+159
| public partial class ExtendedDetailsEntryLabel : OsuSpriteText | ||
| { | ||
| public ExtendedDetailsEntryLabel(LocalisableString text) | ||
| { | ||
| Font = OsuFont.Default.With(size: 12); | ||
| Text = text; | ||
| } | ||
|
|
||
| [BackgroundDependencyLoader] | ||
| private void load(OverlayColourProvider colourProvider) | ||
| { | ||
| Colour = colourProvider.Content1; | ||
| } | ||
| } | ||
|
|
||
| public partial class ExtendedDetailsEntryValue : OsuSpriteText | ||
| { | ||
| public ExtendedDetailsEntryValue() | ||
| { | ||
| Font = OsuFont.Default.With(size: 12, weight: FontWeight.Bold); | ||
| } | ||
|
|
||
| [BackgroundDependencyLoader] | ||
| private void load(OverlayColourProvider colourProvider) | ||
| { | ||
| Colour = colourProvider.Content2; | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
moved these elements into separate classes so as not to duplicate styles each time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i also decided to tidy up the styling a bit and not break the DRY, don't judge me too harshly
osu-web