Always instantiate transformers directly#13114
Open
notbakaneko wants to merge 2 commits into
Open
Conversation
notbakaneko
force-pushed
the
feature/transformers-new-direct
branch
from
988bd3f to
063a869
Compare
using our own TransformerAbstract subclass here because we never use the base one.
notbakaneko
force-pushed
the
feature/transformers-new-direct
branch
from
063a869 to
35332e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No more untyped magic string transformer.
This has been on my todo list for a while and always bugs me when I have to look for transformer usages.