Refactor store checkout related modules

.github/workflows/lint.yml

@@ -55,7 +55,7 @@ jobs:
       - name: Install js dependencies
         run: yarn --frozen-lockfile
 
-      - run: 'yarn lint --max-warnings 44 > /dev/null'
+      - run: 'yarn lint --max-warnings 43 > /dev/null'
 
       - run: yarn pretty
 

app/Http/Controllers/Store/CheckoutController.php

@@ -62,8 +62,9 @@ public function store()
             return ujs_redirect(route('store.cart.show'));
         }
 
-        if ($params['hide_from_activity'] !== null) {
-            $order->setGiftsHidden($params['hide_from_activity']);
+        $hideFromActivity = $params['hide_from_activity'];
+        if ($hideFromActivity) {
+            $order->setGiftsHidden($hideFromActivity);
         }
 
         $checkout = new OrderCheckout($order, $params['provider'], $params['shopifyCheckoutId']);

resources/js/entrypoints/store-bootstrap.ts

@@ -1,6 +1,6 @@
 // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the GNU Affero General Public License v3.0.
 // See the LICENCE file in the repository root for full licence text.
 
-import { Store } from 'store';
+import Store from 'store';
 
-Store.init(window);
+Store.init();

resources/js/main.coffee

@@ -24,7 +24,6 @@ import Menu from 'core-legacy/menu'
 import NavButton from 'core-legacy/nav-button'
 import Nav2 from 'core-legacy/nav2'
 import Search from 'core-legacy/search'
-import { StoreCheckout } from 'core-legacy/store-checkout'
 import TooltipDefault from 'core-legacy/tooltip-default'
 import { navigate } from 'utils/turbolinks'
 
@@ -39,7 +38,6 @@ jQuery.timeago.inWords = (distanceMillis) ->
 
 $(document).on 'turbo:load', ->
   BeatmapPack.initialize()
-  StoreCheckout.initialize()
 
 window.bbcodePreview ?= new BbcodePreview
 window.checkboxValidation ?= new CheckboxValidation