Generalize UserTagPicker#13080
Open
LiquidPL wants to merge 1 commit into
Open
Conversation
RFC. I'm not sure if this is overkill and it'd be easier/cleaner to just copypaste the tag picker layout to a new component, so I'm PR'ing this in for discussion. Intended to be used in a future PR allowing trusted users (and possibly other users in the future) to edit beatmap tags through web.
nanaya
reviewed
Jun 23, 2026
| @import "bem/beatmap-discussions"; | ||
| @import "bem/beatmap-discussions-header-bottom"; | ||
| @import "bem/beatmap-discussions-header-top"; | ||
| @import "bem/beatmap-user-tag-picker"; |
Collaborator
There was a problem hiding this comment.
maybe just call it beatmap-tag-picker instead?
Contributor
Author
There was a problem hiding this comment.
i feel like this would make it too ambiguous whether it concerns mapper tags or user tags. not sure how those are generally named throughout the project
Collaborator
There was a problem hiding this comment.
right. except the mapper tag is attached to beatmapset, not beatmap. and I think user tag is referred as beatmap tag everywhere
Collaborator
There was a problem hiding this comment.
do a two steps commit - one renaming the file, and another one updating the file. Otherwise the history won't get carried over to the new file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC. I'm not sure if this is overkill and it'd be easier/cleaner to just copypaste the tag picker layout to a new component, so I'm PR'ing this in for discussion.
Intended to be used in a future PR allowing trusted users (and possibly other users in the future) to edit beatmap tags through web.