Upgrade dependencies - #740
Open
iamnotaturtle wants to merge 5 commits into
Open
Conversation
run tests, verify they pass
Fix deprecated attribute
fixes broken tests
Fixes deprecated warnings
|
Just had the same issue too 😄 |
Author
|
@danschultzer could you review? |
|
I hate to be that guy, but it would be great if we could get support for modern phoenix versions ❤️ |
|
@danschultzer any possibility to get this merged? |
|
Would be great to get support for phoenix > 1.8 |
|
+1 for this PR. 1.8 is out and this PR is a must |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Upgrading repos using this library led to a warning about being unable to use a newer version of phoenix_live_view.
This change upgrades a few dependencies for this library. The list of dependencies updated are here: https://hex.pm/l/pCnov. The main updates are for
phoenix_live_viewandphoenix. This PR fixes the broken tests.Phoenix.LiveViewTest.DOMnow usesLazyHTMLunderneath, so that needed to be updated.