e2e: fail fast when every interpreter quick pick row is deprioritized - #15240
Open
midleman wants to merge 1 commit into
Open
e2e: fail fast when every interpreter quick pick row is deprioritized#15240midleman wants to merge 1 commit into
midleman wants to merge 1 commit into
Conversation
selectQuickInputElementContaining silently clicked the first match when every row matching the version was deprioritized, which on the Linux CI images means clicking the uv-managed base install instead of /root/.venv before it has registered. That interpreter cannot start, so the failure surfaced 90s later as a /started/ timeout. Throw instead, so the caller's existing retry reopens the picker and gives the venv time to register. Windows and macOS CI install only a bare System/Pyenv Python, where every row is legitimately deprioritized, so those platforms keep the first-match fallback via ALLOW_DEPRIORITIZED_PYTHON_FALLBACK.
|
E2E Tests 🚀 Why these tags?
More on automatic tags from changed files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selectQuickInputElementContainingsilently clicked the first match when every row matching the version was deprioritized. On the Linux CI images that means clicking the uv-managed base install instead of/root/.venvbefore it has registered -- that interpreter cannot start, so the failure surfaced 90s later as a/started/timeout instead of at the picker. Source of a 4.3% ubuntu/electron flake in the Quarto inline-output persistence test.deprioritizeis set and no non-deprioritized row exists, listing the rows that were seenstartAndSkipMetadatanow reopens the picker, giving the venv time to registerALLOW_DEPRIORITIZED_PYTHON_FALLBACKQA Notes
Test-infra only; no product code. Windows and macOS lanes matter here -- they take the fallback path, not the new throw.
Validation Steps
@:quarto @:sessions @:notebooks @:positron-notebooks @:interpreter @:win @:web
E2E Triage Diagnosis
🟢 High confidence -- Test-side: when every quick-pick match is deprioritized, selectQuickInputElementContaining silently clicks the first match (the broken uv managed base interpreter), so the session never starts and the 90s /started/ wait times out.