Skip to content

Detect Source effects - #1341

Merged
lionel- merged 1 commit into
mainfrom
oak-nse/3-source
Aug 3, 2026
Merged

Detect Source effects#1341
lionel- merged 1 commit into
mainfrom
oak-nse/3-source

Conversation

@lionel-

@lionel- lionel- commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Progress towards #1338
Branched from #1340

Moves source() into the effect abstraction introduced in #2, as the third effect kind after NSE and attach. A new SourceAnnotation handler replaces the hand-rolled path parser, and both the scan and the walk now recognize source() the same way they recognize library() or local(), through the shared resolve path instead of matching the name syntactically.

With these changes:

  • source() can be shadowed by a binding or import
  • The source annotation supports multiple files, to allow collated sourcing in the future, e.g. for targets::tar_source()
  • The path argument is wired through CallContext::resolve_string(). It's currently inert but once data flow is hooked in we'll get: p <- "foo"; source(p)

Positron Release Notes

New Features

  • Smarter handling of source() calls.

Bug Fixes

  • N/A

@lionel- lionel- mentioned this pull request Jul 16, 2026
@lionel-
lionel- force-pushed the oak-nse/3-source branch from affa559 to e949bf2 Compare July 17, 2026 08:56
@lionel-
lionel- force-pushed the oak-nse/3-source branch 2 times, most recently from f0219b0 to a6cd15e Compare July 17, 2026 13:55
@lionel-
lionel- force-pushed the oak-nse/3-source branch from a6cd15e to 00372c8 Compare July 22, 2026 12:46
@lionel-
lionel- force-pushed the oak-nse/3-source branch from 00372c8 to 0bb6d81 Compare July 22, 2026 15:25
@lionel-
lionel- force-pushed the oak-nse/3-source branch from 0bb6d81 to 992f9c3 Compare July 28, 2026 12:27
@lionel-
lionel- force-pushed the oak-nse/3-source branch from 992f9c3 to ee50de9 Compare July 30, 2026 14:38
@lionel-
lionel- force-pushed the oak-nse/3-source branch 3 times, most recently from b2664fb to f3b61d7 Compare July 31, 2026 14:23
Base automatically changed from oak-nse/2-attach to main August 3, 2026 16:19
@lionel-
lionel- merged commit 8ffd679 into main Aug 3, 2026
16 of 17 checks passed
@lionel-
lionel- deleted the oak-nse/3-source branch August 3, 2026 16:20
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant