This repository was archived by the owner on Sep 11, 2026. It is now read-only.
Repository navigation
Fix stress test hang: retry on SendToError in echo server - #398
Closed
SeanTAllen wants to merge 1 commit into
Closed
SeanTAllen wants to merge 1 commit into
SeanTAllen wants to merge 1 commit into
Conversation
The echo server was dropping datagrams when send_to returned SendToError, causing the client to hang forever waiting for an echo that will never arrive. Treat SendToError the same as SendToWouldBlock: stash the datagram and retry via the deferred _drain_stash behavior.
ponylang-main
added
the
discuss during sync
Member
Author
|
Closing in favor of a full stress test redesign — the retry approach masks errors the test should be catching. |
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The echo server in the UDP flood stress test silently dropped datagrams when
send_toreturnedSendToError. The client hangs forever waiting for an echo that will never arrive —_recv_cursornever reaches_send_cursor.SendToErroron loopback is typically transient:ECONNREFUSEDfrom a stale ICMP port-unreachable error queued on the socket. The stash-and-retry mechanism already existed forSendToWouldBlock; this change addsSendToErrorto the same code path.The old
_drain_stashhandler forSendToErrorhad a double bug: it dropped the datagram AND didn't reschedule the drain, orphaning everything remaining in the stash.