mrc-6988 fix output buttons bug

[EmmaLRussell]

I noticed that the open output buttons had stopped working and the error logged in the server suggested that it had been trying to open a folder name corresponding to a big chunk of the output log.

I'm not quite sure why the logging from Piranha has changed, but it seems that the regex I use in piranhaAPI to determine the name of the output log had been way too greedy and the match had gobbled multiple lines rather than doing a lazy match. I've joined the log with newlines rather than spaces so that the match should never traverse lines and have also explicitly made the match lazy.

This is awkward to put in an e2e test for as it's about opening other programs - best to just test manually that the "Open report" and "Open output folder" buttons work at the end of a run.

[david-mears-2]

Seems to work, though the logs my job generated wouldn't have failed with the greedy regex in any case (they only listed the summary report in one place).

For unit testing, would it work to update expectedLog in piranha-apps/svelte-app/tests/unit/lib/piranhaAPI.svelte.test.ts to have an adversarial example, i.e. one where greedy-regex would go wrong and lazy-regex wouldn't? And then assert that window.api.openRunOutputFolder was called with the correct parameters?

Current:

const expectedLog = [
      "test log message 1",
      "test log message 2",
      "Generated: /data/run_data/output/output_1/report.html",
    ];

Proposed:

const expectedLog = [
      "test log message 1",
      "test log message 2",
      "Generated: /data/run_data/output/output_1/report.html",
      "Honeypot: /data/run_data/output/honeypot_for_greedy_regex/report.html",
    ];

[david-mears-2]

Why index of 1?