Fix broken add-owner/add-member Graph calls in Groups utilities#1247
Merged
Conversation
UpdateOwners/UpdateMembers in both GroupsUtility and UnifiedGroupsUtility passed accessToken positionally into MakePostRequest parameter 2, which is the request body (object content) - not the access token. This sent the token as the POST body with no auth header and no @odata.id reference payload, so adding owners/members was non-functional. The bug came from the Graph SDK -> HttpHelper migration (2435d06, cf619ed). Align all four add/remove paths with the working ObjectTeams pattern: - POST .../{owners|members}/$ref with an {"@odata.id": ".../users/{id}"} body, application/json content type, and accessToken in the correct slot - Correct the DELETE reference URLs from /ref to /$ref Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
RemoveGroupMembers/RemoveGroupOwners and RemoveUnifiedGroupMembers/ RemoveUnifiedGroupOwners build their DELETE reference URL with /ref instead of /$ref, so member/owner removal via these methods (and the Clear* methods that delegate to them) hit an invalid Graph endpoint. Correct the four sites to /$ref, matching the Update* methods and the ObjectTeams pattern. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
|
Thanks a lot @singingknight for fixing this, much appreciated !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpdateOwners/UpdateMembers in both GroupsUtility and UnifiedGroupsUtility passed accessToken positionally into MakePostRequest parameter 2, which is the request body (object content) - not the access token. This sent the token as the POST body with no auth header and no @odata.id reference payload, so adding owners/members was non-functional. The bug came from the Graph SDK -> HttpHelper migration (2435d06, cf619ed).
Align all four add/remove paths with the working ObjectTeams pattern: