Skip to content

Bugfix: datepicker updatemode="bothdates" not always respected#3811

Merged
KoolADE85 merged 4 commits into
devfrom
bugfix/3425-datepicker-bothdates
Jun 30, 2026
Merged

Bugfix: datepicker updatemode="bothdates" not always respected#3811
KoolADE85 merged 4 commits into
devfrom
bugfix/3425-datepicker-bothdates

Conversation

@KoolADE85

@KoolADE85 KoolADE85 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Fixes a bug in DatePickerRange when updatemode="bothdates".

To reproduce:

  1. Create a DatePickerRange attached to a callback:
dcc.DatePickerRange(
    start_date=date(2021, 1, 1),
    end_date=date(2021, 1, 31),
    updatemode="bothdates",
    id="dpr",
),
  1. Start a new date selection by changing the dates
  2. Observe that the callback fires before both dates are selected (updatemode not respected)

Fixes #3425

Contributor Checklist

  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md

@KoolADE85 KoolADE85 changed the title Bugfix:3425 datepicker bothdates Bugfix: datepicker updatemode="bothdates" not always respected Jun 10, 2026
KoolADE85
KoolADE85 commented Jun 10, 2026
View reviewed changes
Comment thread components/dash-core-components/tests/integration/calendar/test_portal.py

action = ActionChains(dash_dcc.driver)
action.move_to_element_with_offset(popover, 10, 10).click().perform()
action.move_by_offset(10, 10).click().perform()

@KoolADE85 KoolADE85 Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the bug - this just addresses a flaky test when run locally.

@camdecoster camdecoster self-assigned this Jun 25, 2026
camdecoster
camdecoster approved these changes Jun 30, 2026
View reviewed changes

@camdecoster camdecoster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested a demo app and the update fixed the issue.

@camdecoster camdecoster assigned KoolADE85 and unassigned camdecoster Jun 30, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jun 30, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@KoolADE85 KoolADE85 merged commit 27c7f7f into dev Jun 30, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camdecoster camdecoster camdecoster approved these changes
@T4rk1n T4rk1n Awaiting requested review from T4rk1n T4rk1n is a code owner
@ndrezn ndrezn Awaiting requested review from ndrezn ndrezn is a code owner

Assignees

@KoolADE85 KoolADE85

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] DatePickerRange updatemode not respected

2 participants

@KoolADE85 @camdecoster