Skip to content

♻️ Change Currency to class #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
greymistcube wants to merge 6 commits into
base: main
Choose a base branch
from
+214 −357
Open

♻️ Change Currency to class #3888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5a1cdf3
Changed Currency from struct to class
greymistcube Jul 19, 2024
cbc7995
Added missing validity checks
greymistcube Jul 19, 2024
f00f5c5
Funneled deserialization of IValue to private constructor; added
greymistcube Jul 19, 2024
794c694
Funneled ISerializable serialization to a private constructor
greymistcube Jul 19, 2024
fe0d8a1
Changelog
greymistcube Jul 19, 2024
14f9a9d
Applied suggestions
greymistcube Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ To be released.

### Backward-incompatible API changes

- (Libplanet.Types) Changed `Currency` from a `struct` to a `class`.
[[#3888]]
- (Libplanet.Types) Changed `Currency()` to throw an `ArgumentException`
if an argument for `ticker` has leading and/or trailing white spaces.
[[#3888]]

### Backward-incompatible network protocol changes

### Backward-incompatible storage format changes
Expand All @@ -20,10 +26,15 @@ To be released.

### Bug fixes

- (Libplanet.Types) Fixed several bugs where an invalid `Currency` object
could be created through deserialization. [[#3888]]

### Dependencies

### CLI tools

[#3888]: https://github.com/planetarium/libplanet/pull/3888


Version 5.2.2
-------------
Expand Down
Loading