send only allowed file types to iThenticate#97
Open
forgive38 wants to merge 1 commit into
Open
Conversation
Member
|
@forgive38, just curious -- what happens when an unsupported file type is uploaded to the iThenticate service? |
Contributor
Author
|
@asmecher : there is an error when you schedule the detection For example, screenshot for the file J.png And since all files of a new submission are automatically sent to iThenticate, that adds an extra delay: it impacts the ui experience (sending files to iThenticate is synchronous, maybe it can be asynchronous via a Job ? - I will make an issue) |
Member
@forgive38 I think thats a good idea. but as that going to some good amount of enhancement(probably), I may suggest to go for such major change in 3.5+ compatible only . But a separate issue is a good place to discuss about that . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hello
I propose this PR in order to restrict the number of files sent to iThenticate, based on iThenticate allowed file types.
I hope that helps,
Thank you