Skip to content

Address PR review: panel sizing, credentials, fallback errors, opt-in logging#3

Merged
pkamble-ks merged 1 commit into
masterfrom
keeper-nsf-support
Jun 26, 2026
Merged

Address PR review: panel sizing, credentials, fallback errors, opt-in logging#3
pkamble-ks merged 1 commit into
masterfrom
keeper-nsf-support

Conversation

@pkamble-ks

Copy link
Copy Markdown
Owner

Summary

Addresses maintainer review feedback on upstream PR gnachman#682 (Keeper Nested Shared Folder support).

  • New Account panel: Default height restored to 136px; expands to 196px only when the adapter declares an add-account toggle.
  • Credentials: Removed keychain settings cache; restored login-credential precedence over settings keychain value.
  • Adapter fallback: For unprefixed account IDs, only try the second Commander verb on not-found/wrong-type errors (preserve first meaningful error).
  • addRecord: Validate record UID from structured fields (and message fallback) before returning.
  • Logging: Opt-in via ITERM2_KEEPER_ADAPTER_LOG_ENABLED=1 (default off).
  • Release notes: Replaced em dash with period per project style.

--force on add/update confirmed against live Commander Service Mode (see upstream PR comment).

Test plan

  • cd pwmplugin && swift test --filter KeeperIntegrationTests (21/21)
  • Manual: Bitwarden/KeePassXC Add Account panel (no extra gap)
  • Manual: Keeper Add Account panel (toggle visible, panel expanded)

@pkamble-ks
pkamble-ks merged commit 63cda37 into master Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant