Feature/common layout and record UI - #39
Open
seunngh wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
종류
무엇을 / 왜
공통
base.html(phone-frame + 하단 5탭 네비게이션)과common.css의 static 경로를실제 참조 경로에 맞게 정리했습니다.
earn_record_form.html/record_choice.html/spend_record_form.html세 화면에 공통 레이아웃 적용을 완료했습니다.상단 타이틀 정렬 문제를 수정했습니다.
관련 이슈
Closes #38
Closes #37
변경 사항
common.css를static/common/common.css→static/css/common.css로 위치 정리 (base.html static 태그 경로 불일치 수정)base.html공통 레이아웃(phone-frame, 하단 네비게이션) 정리earn_record_form.html,record_choice.html,spend_record_form.html세 화면에 공통 레이아웃({% extends "base.html" %}) 적용 완료.field-block + .footer-actions)테스트 방법
docker-compose up으로 로컬 실행/ledger/record/earn/?mode=timer접속 → 타이머 시작 → 종료 눌러 결과 패널이 화면 하단에 자연스럽게 붙는지 확인/ledger/record/earn/?mode=manual접속 → 시간/분 입력 시에도 동일하게 확인common.css)가 정상 적용되는지 확인 (경로 변경 영향 범위 체크)스크린샷
체크리스트
docker-compose up)feat:,fix:,docs:...)을 지켰다.env등 시크릿은 커밋에 포함되지 않았다